test(daemon): bound idle frontend maintenance probes - #2215

Thanks for opening this — it has been seen, and it is queued.

This note is automated, but it is not a brush-off: it exists so you know where your PR stands instead of having to guess from silence.

Current review status: working through a backlog. 0.9.1-rc.1 is out, so the release freeze that held reviews is over — but it left a large queue of open pull requests behind it, and we are reading through them oldest-first. The background is in discussion #1144.

What that means for this PR, concretely:

• It will not be closed for inactivity. No stale bot touches pull requests here.
• It may still sit a while before a human reads it. That is on us, not on you.
• Older PRs are read first, so a recent one is not being skipped — it is behind a queue.

Things that will genuinely speed it up whenever review does happen:

• Keep it rebased on main — the tree is moving quickly right now, and a conflicting branch cannot be reviewed as the diff you intended.
• Get CI green, or say which failures you believe are pre-existing.
• Keep the change to one claim. Bundled features and refactors get split before they get merged, which costs you a round trip.
• Every commit needs a sign-off (git commit -s) — CI enforces DCO.

If this fixes a bug, a reproduction we can run is worth more than a description of the symptom.

Thanks for contributing, and sorry in advance for the wait.

Thank you for the eviction regression. The test's fixed 100 ms sleep is shorter than the current 250 ms production idle interval, so elapsed sleep is not a deterministic proof that eviction reached the intended state. Please make the test control or observe the relevant state transition rather than increasing the sleep budget or adding retries.

Thank you — bounding idle frontend maintenance probes is a good guard to have, and 21 lines in one test file is an easy review.

One blocker, and it is the only thing standing between this and a merge: the dco check.

Your commit carries no Signed-off-by trailer — the message is a headline with an empty body, so there is nothing for the check to parse. (It is not the blank-line trap, where a sign-off sits outside the trailer block and git's parser ignores it while grep still sees it. Here there is genuinely no trailer.)

git commit --amend -s
git push --force-with-lease

Every other check on this PR is green (31 success, 1 skipped). Sign it off and I will merge it.

A note on how I will review it once it is green, since it is a test-only change: I check that a new test can actually fail, by reverting the production code it covers and confirming the test goes red. A test that passes with the behaviour removed proves nothing, and this repository has shipped a few of those. For a pure guard like this one, the question I will be asking is whether an unbounded probe loop would actually trip it — if you already know it does, saying so in a sentence saves me the round trip.

For what it is worth: #2241 and #2242 were signed off correctly and both merged today after exactly that check. Nice work on those.